search

gregmuellegger / django-mobile

Detect mobile browsers and serve different template flavours to them.
http://pypi.python.org/pypi/django-mobile
BSD 3-Clause "New" or "Revised" License
560 stars 170 forks source link

Added detection of Amazon CloudFront mobile viewer header #62

Closed mjbrams closed 8 years ago

mjbrams commented 8 years ago

This enables people that are using CloudFront to rely on their detection of mobile viewers.

gregmuellegger commented 8 years ago

Hi thanks for this proposal. I won't merge this change as it implies support for external services. If we agree on supporting Amazon CloudFront, then we would need to support all other services that anyone would want. I think this usecase is too particular for this very generic app.

You can add support in your project for CloudFront easily by subclassing the middleware class. Thanks for the efforts and the will to contribute.

mjbrams commented 8 years ago

Thanks for the quick reply and a great project.

From: Gregor Müllegger [mailto:notifications@github.com] Sent: Wednesday, December 9, 2015 5:33 PM To: gregmuellegger/django-mobile django-mobile@noreply.github.com Cc: Michael J Brams michael.brams@3top.com Subject: Re: [django-mobile] Added detection of Amazon CloudFront mobile viewer header (#62)

Hi thanks for this proposal. I won't merge this change as it implies support for external services. If we agree on supporting Amazon CloudFront, then we would need to support all other services that anyone would want. I think this usecase is too particular for this very generic app.

You can add support in your project for CloudFront easily by subclassing the middleware class. Thanks for the efforts and the will to contribute.

— Reply to this email directly or view it on GitHubhttps://github.com/gregmuellegger/django-mobile/pull/62#issuecomment-163421738.