gregnavis / active_record_doctor

Identify database issues before they hit production.
MIT License
1.76k stars 55 forks source link

Suggest using config file with `.rb` extension #161

Closed fatkodima closed 11 months ago

fatkodima commented 11 months ago

Fixes #159.

Backwards compatibility is preserved to also accept .active_record_doctor files by default (without extension), if present.

jdufresne commented 11 months ago

@gregnavis Do you feel #162 solves what you're looking for? Feedback is welcome.

gregnavis commented 11 months ago

@jdufresne, I hadn't noticed you also opened a PR when I was reviewing this. I opened another PR and wanted to ask you and @fatkodima for a quick review. Let me leave some feedback on your PR, so that it's clear why I chose a slightly different path.

Thank you for your contributions!

gregnavis commented 11 months ago

Closing in favor of #166.