Searchbox can be closed and disappears despite searchOpen: true

[mxmlnglt]

Following this showcase: https://codesandbox.io/s/muidatatables-misc-requests-4vkxk

When you set both:

      search: false,
      searchOpen: true,

The searchbox is open (always, as it seems...) and the search icon is disabled: this is to meet our user's requirement i.e. always have a search box.

However:

• searchbox CAN be closed; it shouldn't, as there is NO way to re-enable it.
• searchbox IS closed when you click either on View Columns or Filter Table icons (doesn't happen if you click on Download or Print) - already reported here https://github.com/gregnb/mui-datatables/issues/1203

[wdh2100]

Thanks for report

      search: false,
      searchOpen: true,

The two conditions seem to contradict.

As you can see, it can cause bugs. We need to change the priority of the two conditions.

[mxmlnglt]

I added a link to https://github.com/gregnb/mui-datatables/issues/1203 for the 2nd bullet point.

[patorjk]

searchOpen should have probably been named searchInitiallyOpen, but I don't want to mess with the name.

In the current setup, an always open search can be accomplished by overiding the Toolbar component via a custom toolbar component. However, this use case seems useful enough that there should probably be an easier solution. I see two options:

• Add a "searchAlwaysOpen" option. The downsides to this are that then the title of the table is never visible and it complicates the logic.
• Pass the various toolbar methods to customToolbar (this would also solve https://github.com/gregnb/mui-datatables/issues/1285).

For the second option, customToolbar would get access to Toolbar's inner workings, similar to the customSearchRender function. Then making a custom search that's always open could be done the same way customSearchRender is done, ex:

customToolbar: (toolbarMeta) => {
    return (
        <CustomSearchComponent
            searchText={toolbarMeta.searchText}
            onSearch={toolbarMeta.handleSearch}
            options={toolbarMeta.options} />
    );
}

The search would be rendered on the right of the toolbar and never interfear with the title (side note: dispite its name, customToolbar simply adds stuff on the right side of the toolbar). I'm leaning towards the second option. In fact, if a disableClose option was added to TableSearch, one could possibly just plug that component into customToolbar.

Or it could make sense to do both, I'm not sure.