search

gregnb / mui-datatables

Datatables for React using Material-UI
MIT License
2.71k stars 932 forks source link

selectToolbarPlacement: 'none' and isRowSelectable not working well together #1619

Open zetedi opened 3 years ago

zetedi commented 3 years ago

selectToolbarPlacement: 'none' isRowSelectable: boolean function, e.g. 

isRowSelectable: (dataIndex) => {
  return dataIndex % 2 === 1;
}

Expected:

Clicking on select all checkbox in the header selects all items which are selectable.

Current:

Nothing is selected. If selectToolbarPlacement is set to 'above' or 'replace', it is working well.

https://codesandbox.io/s/vigorous-mendel-t8bjs

Tech Version
Material-UI 4.11.2
MUI-datatables 3.7.3
React 17.0.0
browser Any
SmoochieMcWallace commented 3 years ago

Removing the complete selection seems to be working fine though. Also, the rowSelectionChange action is fired correctly.

punniyamoorthielangovanv commented 7 months ago

Hi All, The reported issue got resolved? Still i can able to reproduce