search

gregnb / mui-datatables

Datatables for React using Material-UI
MIT License
2.71k stars 932 forks source link

Warning: Failed prop type: Material-UI: you are using a deprecated typography variant: `subheading` that will be removed in the next major release. #354

Open jkeruzec opened 5 years ago

jkeruzec commented 5 years ago

Please upgrade material-ui typography variant to latest version.

Thanks :)

gregnb commented 5 years ago

It'll be done tonight

mking42 commented 5 years ago

Duplicate of: https://github.com/gregnb/mui-datatables/issues/333

aishmit commented 5 years ago

I seem to be getting same error, running the latest version of material-ui/core and latest version of mui-datatables

When i expand the error it points towards getMuiTheme() image

jkeruzec commented 5 years ago

FYI, Material UI is preparing a version V4 with removal of deprecated behaviour.

https://github.com/mui-org/material-ui/issues/13663

gregnb commented 5 years ago

This issue has been resolved in beta-53. Please let me know if there are any further problems

foxmicha commented 5 years ago

Still receiving this issue in 2.0.0-beta-53:

image

Code in question:

getMuiTheme = () => createMuiTheme({
        overrides: {
            //@ts-ignore
            MUIDataTableBodyCell: {
                root: {
                    padding: "4px"
                }
            },
            MUIDataTableHeadCell: {
                root: {
                    padding: "4px"
                }
            }
        }
    })

    render() {
        return (
            <>
            <MuiThemeProvider theme={this.getMuiTheme()}>
                <MUIDataTable
                    title={"DataTable Demo"}
                    data={randomData}
                    columns={muiDataTableColumns}
                    options={options}
                />
            </MuiThemeProvider>
            </>
        );
    }
gregnb commented 5 years ago

@foxmicha Can you provide your environment information? mui ver, etc

foxmicha commented 5 years ago

material-ui/core: 3.7.1 material-ui/icons: 3.0.2 mui-datatables: 2.0.0-beta-53