search

gregneagle / relocatable-python

A tool for building standalone relocatable Python.framework bundles
Apache License 2.0
156 stars 42 forks source link

add support for `--without-pip` option #12

Closed benoit-pierre closed 3 years ago

benoit-pierre commented 3 years ago

When used, don't make pip available, or install any extra python modules.

gregneagle commented 3 years ago

What problem is this intended to solve? If you don't want to install any additional modules, provide an empty requirements file. (Sure, pip itself will still be installed, but is that a problem?)

benoit-pierre commented 3 years ago

It's to avoid unnecessary operations (especially with the slow macOS runners on GitHub Actions), and avoid hitting the PyPI index: I already have a mechanism to bootstrap everything once the interpreter is setup that ensure I have exactly the correct (pinned) versions of pip / wheel / setuptools installed, and that we'll re-use a custom cache. So it's about speed and control.

I think using --requirements=/dev/null was also resulting in an error in one of my use case (creating an App Bundle for the Plover project), let me check again.

benoit-pierre commented 3 years ago

OK, so the error is the script failing to access the PyPI index if PIP_NO_INDEX=1 is set.

benoit-pierre commented 3 years ago

Superseded by #20.