gregorgorjanc / AlphaSimR

R package for breeding program simulations
Other
0 stars 2 forks source link

Imprinting new functions #4

Open david20011999 opened 10 months ago

david20011999 commented 10 months ago

As we talked, here you have my pull request for check new imprinting functions before send to Chris pull request. You will find:

Future and potential steps:

david20011999 commented 7 months ago

Simulating an imprinted and a non-imprinted trait, when bv() function is required, originates a bug. This is due to the fact that lines 534 and 538 of popSummary.R are substituing bv to imprinting bv in all traits, not just the imprinted trait. To fix this, ret[sel, ] has to be changed to ret[sel, impTest]. I have done it in my computer version, I will upload it to my github as soon as possible.

gregorgorjanc commented 7 months ago

@david20011999 i have fallen behind in this work of yours! Sorry. We need to start looking at this during our meetings. Please put it on our agenda. Maybe we will also have to start meeting more regularly.

I think that the 1seg site change should best be submitted as a PR right away to Chris’s repository upstream - that is not related to imprinting. Please do that - fork a fresh upstream, clone it, modify it, push, and open a PR for Chris to revise.