Accepted updated results after merging gregorio-project/gregorio#1154.

gregorio-project / gregorio-test

A repository of tests for Gregorio

GNU General Public License v3.0

5 stars 3 forks source link

Accepted updated results after merging gregorio-project/gregorio#1154. #242

Closed henryso closed 8 years ago

henryso commented 8 years ago

Tests gregorio-project/gregorio#1153.

@jakubjelinek Please review these three PDFs and let me know if they are correct according to you. Compared to the older code, it seems that the non-diastematic neumes are closer to the score.

The tests in release-4.2 currently break because of these three tests. The results do not look bad to me per se, so if I hear no response for a couple of days, I will merge this.

jakubjelinek commented 8 years ago

Looks good to me. The whole point of the changes was to make sure that by default the presence or absence of high quadrata notes does not affect nabc vertical placement, in all these cases where there has been a move downward there were such notes. Users that want to keep previous behavior can just set the abovetextnabcthreshold to 0, or if there is a clash between quadrata and nabc one can always manually move selected (usually just a couple) of nabc neumes up using hX.

jakubjelinek commented 8 years ago

BTW, should the new additionaltopspacenabcthreshold macro be mentioned in Command_Index_User.tex ? Something also in Command_Index_internal.tex ?

henryso commented 8 years ago

@jakubjelinek I should have noticed, but you are right.

additionaltopspacenabcthreshold should be added as a new count to Command_Index_User.tex
\gre@typesettextabovelines should be updated (to document the #2 argument) in Command_Index_internal.tex
\GreSetNabcAboveLines should be added to Command_Index_gregorio.tex