Added and updated tests for the ledger line change.

gregorio-project / gregorio-test

A repository of tests for Gregorio

GNU General Public License v3.0

5 stars 3 forks source link

Added and updated tests for the ledger line change. #267

Closed henryso closed 7 years ago

henryso commented 7 years ago

Tests gregorio-project/gregorio#1215. Corresponds with gregorio-project/gregorio#1232.

eroux commented 7 years ago

Generally speaking, the code changes look ok to me and we can delay the feature of the clivis, but I cannot see any change in https://github.com/henryso/gregorio-test/blob/a89b6be327ec8585c6e24f3b7d0f1539a0b57c93/tests/gabc-output/bugs/fix-1215.pdf which still looks the same as what was reported in #1215 ... ?

henryso commented 7 years ago

dd and ee are different, but you're right; in going back and forth, I lost the fix for bb and cc. I'll work on it, but I'm not sure I'll be able to complete it this weekend.

eroux commented 7 years ago

ok, no hurry!

henryso commented 7 years ago

The fix is in. Please review.

eroux commented 7 years ago

Looks perfect, thanks!