Closed rpspringuel closed 6 years ago
Done.
Changes up, but I noticed that the original definition of $processors
dumped stderr to /dev/null. Should I do the same for the new definitions?
I don't think it's necessary to dump stderr to /dev/null in the newer method. The main reason for doing that before was to hide the nasty message should there be no nproc
on the system. In the code you added, you are detecting the operating environment so you would want the user to know if there is a problem running sysctl
or nproc
.
An undefined variable
$processors
was being used to pass the number of processors toxargs
in order to run multiple tests in parallel. This change renames the variable to$NPROCESSORS
, defines a default value (the number of addressable processors reported by the system) and allows the user to change that number with a setting ingregorio-test.rc
Addresses #321