search

gregorio-project / gregorio-test

A repository of tests for Gregorio
GNU General Public License v3.0
5 stars 3 forks source link

Differentiation error message #330

Closed rpspringuel closed 5 years ago

rpspringuel commented 5 years ago

When an expectation image cannot be found the image comparison is skipped and the test fails. Previously, however, this was reported as a "Results differ" failure, implying that the comparison was run. This change makes it so that the reported error message indicates the real cause of the test failure (missing expectation image).

rpspringuel commented 5 years ago

I've added a second commit which outputs a message indicating a possible remedy for this failure. We don't do this for any other failure, so if others don't like it I'll revert that commit.

rpspringuel commented 5 years ago

It occurs to me that it would be useful if the image cache folder was removed when the convert command to populate it fails. I will add that to this PR later tonight or tomorrow.

rpspringuel commented 5 years ago

And changes are done. Please review and alert me to any problems.

henryso commented 5 years ago

By the way, thanks for this improvement. I see this repo as a quality-of-life thing for developers so I don't pay the "niceness" of it too much mind, so it's good that you do.