search

gregorio-project / gregorio-test

A repository of tests for Gregorio
GNU General Public License v3.0
5 stars 3 forks source link

Backward mode for gregorio-test.sh #346

Open rpspringuel opened 3 years ago

rpspringuel commented 3 years ago

There should be a backward mode for gregorio-test.sh which will convert given TEST into a backwards compatibility test (copying the files into backwards/ and adding the _B as appropriate).

Further, review-results.sh should have an option where a failed test can be converted to a backwards compatibility test (with the current expectation) and the result (which failed against the old expectation) made into the future expectation for that test.

henryso commented 3 years ago

How is that different than accepting the result as the new expectation for the current test?

rpspringuel commented 3 years ago

The issue is when the backwards compatibility test doesn't yet exist. This option would create the backwards/TEST using the existing tests/TEST as the basis (copying all related files and modifying the filenames). One would do this for a test which involves code which has been deprecated. Once the backwards compatibility test is created, you'd then (if needed) modify the tests/TEST to not use the deprecated code and (if that also changes the result) accept the result as the new expectation.