search

gregorio-project / gregorio

The Gregorio Project
http://gregorio-project.github.io
Other
164 stars 43 forks source link

Redundant distance? #1507

Closed rpspringuel closed 3 years ago

rpspringuel commented 3 years ago

While running doc_check.sh on another issue I noticed that we have both unisonpunctuminclinatumshift and punctuminclinatumunisonshift defined in gsp-default.tex. Both are set to the same value by default. Each is only used once in \gre@get@spaceskip: one for case 23, the other for case 26, neither of which is documented explaining that function (the cases only go up to 22).

This raises the question: do we need both of these or is one redundant and should be changed to the other?

(Also, we should fix the documentation here to document all the cases above 22 when fixing this.)

henryso commented 3 years ago

23 is used when you have two "puncta inclinata" on a unison. 26 is used when you use the non-leaning "punctum inclinatum" after a non-"punctum inclinatum". They could be merged, but I don't feel qualified to decide that.

rpspringuel commented 3 years ago

So case 26 isn’t really unison related?

Sent with GitHawk

henryso commented 3 years ago

I think that's a fair assessment. The non-leaning punctum inclinatum is set to be used at the unison, but in the end this space case is used regardless of the previous note's pitch.

rpspringuel commented 3 years ago

Then I would suggest that the distance associated with said case be renamed and the documentation updated.

rpspringuel commented 3 years ago

@henryso Can you indicate what the other two cases are for (24 & 25)?

henryso commented 3 years ago

24 is used before a right-leaning puncta inclinata when the pitch is ascending (up to 4 pitches away). 25 is used before a left-leaning puncta inclinata when the pitch is descending (up to 4 pitches away).