search

gregorio-project / gregorio

The Gregorio Project
http://gregorio-project.github.io
Other
164 stars 43 forks source link

Made $ into a text escape character. #1522

Closed henryso closed 3 years ago

henryso commented 3 years ago

Fixes #1515

The lexer changes were pretty straightforward, but the gabc output was a bit tricky. It seems to pass the tests satisfactorily, so I think it's working well enough though there may be some obscure bugs.

henryso commented 3 years ago

Note: the documentation doesn't build because of uprightpunctuminclinatumshift rename. I think some merging needs to be done.

rpspringuel commented 3 years ago

I've been caught up in some problems in my own work, but I should be able to look at this later today.

rpspringuel commented 3 years ago

@henryso I've also submitted a PR against this branch in your fork of the repository.

henryso commented 3 years ago

I don't think there are any remaining open questions here (but it is a bit hard to follow).

henryso commented 3 years ago

Looks like the gabc writer doesn't escape the bracketed instructions inside the notes. I'll working on that. Might take a bit.

henryso commented 3 years ago

OK, how does this look?

rpspringuel commented 3 years ago

I think that about covers it.