gregorio-project / gregorio

The Gregorio Project
http://gregorio-project.github.io
Other
164 stars 43 forks source link

Update to scribus configuration file #1524

Closed rpspringuel closed 3 years ago

rpspringuel commented 3 years ago

There have been some changes to the filecontents environment that need to be addressed. Fixes #1523

rpspringuel commented 3 years ago

Can you post a copy of the tex file that Scribus creates? I'm need to see what the filecontents* environment contents end up being to make more educated guesses as to how to make this work.

Is there a reason that gregorio does not ignore white space not contained between : and ; preceding the %% in a .gabc file?

The reason is mostly that we never thought about that possibility. We always assumed that gabc file writing would be done by hand. Unfortunately, scribus, while using an XML file to define a rendering frame, doesn't really understand the indentation of an XML file and thus sometimes thinks XML indentation should be part of the target file it's supposed to create. Further, we actually need to write two files (the gabc and the tex file) while the render frame tool only expects to need to write one. Thus we have to design the tex file to create the second automatically in a way that is compatible both with how Scribus interprets the XML and with how filecontents interprets its contents. Getting such indirection right is complicated (especially since none of the developers actively use Scribus and thus testing requires one of us to relearn it each time we run into problems).

@henryso, Could the lexer be modified to ignore spaces in header names?

EagerDSC commented 3 years ago

If </preamble> is up the line in 900_gregorio.xml then here are the two situations:

Given the default input to the Scribus render frame editor, these are gabc, gtex, and glog files that are generated. DefaultInput.zip

Given the default input preceded by a blank line, these are the gabc, gtex, and glog files that are generated. WithBlankLineFirst.zip

If </preamble> is down on its own line in 900_gregorio.xml, then here are the two situations:

Given the default input to the Scribus render frame editor, these are gabc, gtex, and glog files that are generated. DefaultInputPreambleOwnLine.zip

Given the default input preceded by a blank line, these are the gabc, gtex, and glog files that are generated. WithBlankLinePreambleOwnLine.zip

rpspringuel commented 3 years ago

I need to see the tex files (not the gtex). I need to know what scribus itself is writing. All of these files are produced by LuaTex after scribus has already (mal-)formed the tex file.

EagerOrthodox commented 3 years ago

I think these are what you are looking for, despite the fact that they appear to have no file extension.

WithBlankLinePreambleUpLine.zip WithBlankLinePreambleOwnLine.zip DefaultInputPreambleUpLine.zip DefaultInputPreambleOwnLine.zip

rpspringuel commented 3 years ago

Okay, one more go. Based on what those files looked like, I think this should eliminate the need for the extra blank line in the input box. @EagerDSC @EagerOrthodox Please test and report back.

rpspringuel commented 3 years ago

Thanks for testing. Glad we could get it working.