search

gregorio-project / gregorio

The Gregorio Project
http://gregorio-project.github.io
Other
155 stars 43 forks source link

Full size bar lines being rendered poking up #1586

Open Nokel81 opened 5 months ago

Nokel81 commented 5 months ago

gregorio verison: 6.0.0

When rendering a full bar (:) or double bar (::) the line seems to extend a little above the top horizontal line.

image image

rpspringuel commented 3 months ago

While I think the issue is being exaggerated in the first image by the pdf renderer, I can confirm that the second image I see the same thing as the second image when I zoom in sufficiently. Unfortunately my fontforge installation is currently not working so I can't actually try to fix this at the moment.

Nokel81 commented 3 months ago

Yeah I agree that the above issue is probably the PDF renderer (which in this case is Adobe IIRC) i think it might be fixed if we fix the other issue too.

If this is a font issue, I have an installation of fontforge up and running, how would I go about fixing that?

rpspringuel commented 3 months ago

There are two possibilities that need to be explored:

1) the bar line is being placed too high. Checking this doesn’t involve any font changes, but rather playing with the way glyphraisevalue is calculated for the bar to get a slightly smaller number. If you can lower the bar line glyph without it sticking out below the bottom line of the staff, then this would be the solution.

2) the bar line glyph is too tall. Fixing this is what would involve editing the fonts to shorten the bar line glyph.

Sent with GitHawk