search

gregorio-project / gregorio

The Gregorio Project
http://gregorio-project.github.io
Other
164 stars 43 forks source link

adapt to new LaTeX version #629

Closed eroux closed 9 years ago

eroux commented 9 years ago

There's a new move in LaTeX to adapt to new engines such as LuaTeX (better late than never!), so a few changes will come with the new version of LaTeX, see announcement. Gregorio is affected by these changes, especially by the removal of the luatex prefix of primitives like localleftbox and localrightbox, and also by the change in the attribute allocators. As Gregorio is not yet integrated into TeXLive, I think it should adapt to both versions (old and new).

rpspringuel commented 9 years ago

I'm reopening this issue because I've just discovered a related problem:

fontspec andgregoriotexaren't playing together seamlessly. Iffontspecis loaded beforegregoriotex, everything works as expected. However, whengregoriotexis loaded first, then I get the error: Undefined control sequence:\xetex_suppressfontnotfounderror:D`.

For me, at least, this means many of our tests fail as they load gregoriotex first.

There are, as I see it, two possible fixes:

  1. Modify the documentation to indicate that fontspec if used, should be loaded before gregoriotex. This would also mean modifying the tests so that they comply with this order.
  2. Make some technical fix so that gregoriotex doesn't interfere with fontspec.

I've no idea how to make the second (and it may involve waiting for wspr/fontspec#217 to be resolved), but can do the first myself fairly easily.

henryso commented 9 years ago

I noted this issue in #633, but didn't realize it correlated to load order. Since things are in flux as people fix bugs in packages, I say we do the former (document and update tests).

rpspringuel commented 9 years ago

Okay, I'll work on that later tonight and submit PRs with the necessary changes.