gregoriusxu / booksleeve

Automatically exported from code.google.com/p/booksleeve
Other
0 stars 0 forks source link

Hashes.Increment is limited to 32-bit int (wrong prototype) #52

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Task<long> Increment(int db, string key, string field, int value = 1, bool 
queueJump = false);

This definition is wrong: it uses "int value = 1" which clearly looks like a 
typo because it should be "long" instead. The returned value is correctly set 
to long.

The override of the above
Task<double> Increment(int db, string key, string field, double value, bool 
queueJump = false);
masks the problem in some cases, when passing long as value (it gets converted 
to double) and not type checking the result.

Original issue reported on code.google.com by fireball...@gmail.com on 27 Dec 2013 at 4:52

GoogleCodeExporter commented 8 years ago
This is addressed in StackExchange.Redis, the successor to BookSleeve

Original comment by marc.gravell on 20 Mar 2014 at 12:08