search

gregory-halverson / json-simple

Automatically exported from code.google.com/p/json-simple
Apache License 2.0
0 stars 0 forks source link

Issue regarding the fallback alternative in JSONValue.toJSONString #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi,

Right now the fallback of JSONValue.toJSONString is:

         return value.toString();

Wouldn't something like the following be better, since the current
implementation can render invalid JSON with a bad toString?

         return "\"" + escape(value.toString() + "\"";

Original issue reported on code.google.com by anders.r...@gmail.com on 30 Jun 2010 at 1:16

GoogleCodeExporter commented 9 years ago 
Looks sane to me too. Blindly returning result of value.toString() is a bug 
IMO. Any way to produce valid JSON is much better than this. Either escape it 
like suggested or return null or "undefined" or whatever.

Original comment by fano...@gmail.com on 14 Jul 2010 at 12:03

GoogleCodeExporter commented 9 years ago

Original comment by fangyid...@gmail.com on 14 Jul 2010 at 1:10

GoogleCodeExporter commented 9 years ago 
Issue 18 has been merged into this issue.

Original comment by fangyid...@gmail.com on 14 Jul 2010 at 1:15

GoogleCodeExporter commented 9 years ago 
Oops, i didn't notice this one, i'm sorry, issue #33 is a duplicate :_(
Anyway, the problem seems to affect writeJSONString as well.
Here's a small patch that seems to work for me...

bye.

Original comment by sanita.c...@gmail.com on 4 Aug 2010 at 9:11

Attachments:

GoogleCodeExporter commented 9 years ago 
Issue 33 has been merged into this issue.

Original comment by fangyid...@gmail.com on 5 Aug 2010 at 12:15

GoogleCodeExporter commented 9 years ago 
hello. I just wanted to ask, if there will be a next version of the json-simple 
library with this enhancement in the near future.

Original comment by berndhub...@googlemail.com on 21 Feb 2011 at 10:44

GoogleCodeExporter commented 9 years ago 
Not sure what does "near future" mean to you, but I do have a plan making some 
improvement of json-simple this year. Will let your guys know once I have any 
update.

Thanks,
Yidong.

Original comment by fangyid...@gmail.com on 22 Feb 2011 at 4:49

GoogleCodeExporter commented 9 years ago 
thanks for the info. The library works also very well in our project, but now 
we are facing the problem that "java.util.Date" classes are not serialized with 
the "", so we get something like this in our json strings:

"birthdate" : Thu Jul 01 00:00:00 CET 1976

But we need something like this, so we can deserialize the date again:

"birthdate" : "Thu Jul 01 00:00:00 CET 1976"

The patch provided here seems to work, but it would be better if the official 
json-simple lib provides this feature/enhancement.

Maybe there is also an other way to format a java.util.date correctly, without 
applying this patch ?

Original comment by berndhub...@googlemail.com on 24 Feb 2011 at 9:28

GoogleCodeExporter commented 9 years ago 
To make it work without modifying anything in json-simple, you may want to call 
toString() of java.util.Date before putting it in a java.util.Map:

json.put("key", aDate.toString())

Thanks,
Yidong.

Original comment by fangyid...@gmail.com on 24 Feb 2011 at 11:22

GoogleCodeExporter commented 9 years ago 
thanks, this seems like a good alternative.

B.Huber

Original comment by berndhub...@googlemail.com on 25 Feb 2011 at 12:46

GoogleCodeExporter commented 9 years ago

Original comment by jon.cham...@gmail.com on 10 Aug 2013 at 4:59