gregoryekhator / moodle-mod_examtimer

GNU General Public License v3.0
0 stars 0 forks source link

function naming violations and in-line functions should not be mixed with class files/. #15

Open danmarsden opened 2 years ago

danmarsden commented 2 years ago

class files like mod_form should just contain a simple class file and shouldn't contain extra in-line functions like these: https://github.com/gregoryekhator/examtimer/blob/main/mod_form.php#L135-L152

Also - those functions are not named correctly either - all functions must use correct frankenstyle naming conventions, so if you move them somewhere else, make sure you follow the naming rules as per: https://moodledev.io/general/development/policies/codingstyle/frankenstyle

note this is a blocker for plugins db approval