search

gregrs-uk / fhodot

Food hygiene open data OpenStreetMap tool
https://gregrs.dev.openstreetmap.org/fhodot/
GNU General Public License v3.0
9 stars 3 forks source link

Consider when to add `source:addr` tag, or possibly warn users about its addition #14

Open Cj-Malone opened 3 years ago

Cj-Malone commented 3 years ago

Is adding source:addr really necessary? It should be on the chnageset anyway.

gregrs-uk commented 3 years ago

source:addr (by extension source) are well-used tags (on OSM objects as well as changesets). Taginfo indicates nearly 86,000 uses of source:addr in the UK (roughly 32,400 of which are source:addr=FHRS Open Data) and it is documented on the wiki as 'especially useful when address data has been imported as it helps us keep a record of where the original data came from'. I feel it's a useful tag as it enables mappers to see at a glance that the address is taken from FHRS data without digging into the history of an object.

If you'd rather not add these tags, you can of course uncheck them when loading objects into JOSM, but I feel this is easier than the users that would like to add these tags adding them in manually (and probably forgetting sometimes).

Cj-Malone commented 3 years ago

The wiki also talks about sources being used on changesets and historically on objects, while it doesn't officially deprecate it on objects it's clearly moving away from it.

But if we move away from that, how about just objects that already have addr:postcode? This sometimes leads to bad data in OSM suggesting the source is FHRS when the changeset only added fhrs:id and source:addr, the actual address was already present.

gregrs-uk commented 3 years ago

An OSM object might have a postcode but no other address data, and when adding addr:* tags from the FHRS data the mapper might decide that it's best to add the source:addr tag, because the address has basically come from FHRS. The FHODOT database currently doesn't store any other addr:* tags apart from addr:postcode, so there's no way to determine whether the FHRS address agrees entirely with the one already in OSM, and therefore whether source:addr is superfluous.

One possibility could be that if the OSM object already has an addr:postcode, a footnote is displayed to make the mapper aware that the source:addr tag will be added but can be deleted as necessary. This may clutter the interface a bit, however.

What do you think?

I won't have any time very soon to implement this though I'm afraid.