search

gregrs-uk / fhodot

Food hygiene open data OpenStreetMap tool
https://gregrs.dev.openstreetmap.org/fhodot/
GNU General Public License v3.0
9 stars 3 forks source link

Exclude closed establishments #24

Open Cj-Malone opened 9 months ago

Cj-Malone commented 9 months ago

Some establishments stay in the dataset after they have closed. It would be nice for them to no longer be shown.

I don't have a programmatic way know if an establishment is closed, however OSM does currently have 4k variations of old_fhrs:id. I've collected them here. Another option would be to allow users of fhodot to flag them.

gregrs-uk commented 9 months ago

Thanks @Cj-Malone. Using old_fhrs:id (which is more common than not:fhrs:id that was suggested in #4) seems like a good way forward, but I haven't entirely thought this through yet, and won't have time to implement it at least for a while.

Cj-Malone commented 9 months ago

I used multiple keys to create that list, old_fhrs:id:2, was:fhrs:id, old:fhrs:id, disused:fhrs:id and old_fhrs:id.

Yeah one is a lot more common than the others, and mappers should use the most common one, but I don't think you should exclusively use it. These tags are not guaranteed to stay in OSM, or even be added in the first place. I think the list of closed should be external, I don't have a strong opinion on if it whether it should be the repo I linked, or your DB. But I do think it should be external.