search

gregrs-uk / fhodot

Food hygiene open data OpenStreetMap tool
https://gregrs.dev.openstreetmap.org/fhodot/
GNU General Public License v3.0
9 stars 3 forks source link

Catch (mass) re-numbering #26

Closed dch0ph closed 7 months ago

dch0ph commented 7 months ago

South Tyneside seems to have a had a mass update of its FHRS IDs, and so the match rate has gone from overnight from ~30% to 0%, which is very disheartening.

Perhaps this could be managed? It would require comparing looking specifically at "old" and "new" FHRS records and identifying a changed FHRS ID where all the address data remained the same. The "suggested match" layer could then be extended to propose "New FHRS ID?".

jnicho02 commented 7 months ago

You're quite right. It has happened in a number of other Local Authorities because someone is hawking a new system around. When they transfer data they regenerate all the identifiers :(

Cj-Malone commented 7 months ago

The postcode matches with the table below the map is the quickest way to update after this. I've started fixing OSM, we'll see how much more needs to be done after the website next updates.

dch0ph commented 7 months ago

I've started fixing OSM, we'll see how much more needs to be done after the website next updates.

That's very heroic - I was looking for a lazy solution!

gregrs-uk commented 7 months ago

As @Cj-Malone said the postcode matches table is the quickest way currently; this table was partly designed for this purpose as frustratingly mass renumbering does seem to happen now and then.

The tool doesn't currently store historical FHRS data so the feature you've suggested would require some quite big changes; I'm afraid it's out of scope at the moment, particularly as I have limited time available.

Closing this issue but feel free to continue discussing progress with South Tyneside here if useful.