search

gregrs-uk / python-fhrs-osm

Python tools and Leaflet maps for downloading, comparing and visualising Food Hygiene Rating Scheme (FHRS) and OpenStreetMap data
http://gregrs.dev.openstreetmap.org/fhrs/
GNU General Public License v3.0
8 stars 2 forks source link

add building=school & potentially others #42

Closed stev-0 closed 7 years ago

stev-0 commented 7 years ago

The official tagging schema for schools is to tag amenity=school for the grounds and building=school for school buildings. As I assume the address should be associated with the building, I think you should allow building=school tags as well which may then show more matches. I guess there could be duplicates with amenity=school as well however.

gregrs-uk commented 7 years ago

Thanks for adding this issue @stev-0. I've given it some consideration but think it would be best to leave it as is.

Firstly, it seems more common to add the addr:xxx tags to the amenity=school way, although adding it to the building or the entrance does seem to make some sense. (GB Taginfo reports 13,407 out of 30,196 amenity=schools having an addr:postcode tag but only 1,628 out of 24,906 building=schools having one.)

Secondly, the comparison tool will already fetch any node or way with an fhrs:id set, including building=schools, and use these in showing matches.

Thirdly, in order for the statistics to be vaguely accurate, it's beneficial for there to be only one OSM entity that would likely match an FHRS establishment. If we add all the building=schools, there will be 2 OSM entities for each school in the FHRS database.

Thanks again.

stev-0 commented 7 years ago

OK, fair enough, can't dispute that reasoning! :)