search

gregrs-uk / python-fhrs-osm

Python tools and Leaflet maps for downloading, comparing and visualising Food Hygiene Rating Scheme (FHRS) and OpenStreetMap data
http://gregrs.dev.openstreetmap.org/fhrs/
GNU General Public License v3.0
8 stars 2 forks source link

Adding address info when fhrs:id is already present in top map #47

Closed spindr closed 6 years ago

spindr commented 6 years ago

A lot of locations in places like Bath, etc. have fhrs:id present -- but no address information. Unfortunately, the top map in the current tool doesn't support adding fixme:addr tags to locations when the fhrs:id is present (even if there's no addr:postcode).

This would help the new quarterly addressing project (especially BS postcodes that are in Bath FHRS :-) Thanks, Neil

gregrs-uk commented 6 years ago

Thanks for spotting this. Looks like a change around line 337 to get_overview_geojson() in __init__.py would solve this i.e. where the text for the map popups is defined.

I will try to have a look at this when I can but pull requests are welcome.

gregrs-uk commented 6 years ago

The 'Postcodes missing/mismatched' table should also get a link to add address info in JOSM.

gregrs-uk commented 6 years ago

Needs a bit more work before being pushed to dev server

spindr commented 6 years ago

Thanks for looking at this.

gregrs-uk commented 6 years ago

Noticed #48 whilst fixing this

gregrs-uk commented 6 years ago

Dev server is now updated and HTML pages have been re-created.