search

gregrs-uk / python-fhrs-osm

Python tools and Leaflet maps for downloading, comparing and visualising Food Hygiene Rating Scheme (FHRS) and OpenStreetMap data
http://gregrs.dev.openstreetmap.org/fhrs/
GNU General Public License v3.0
8 stars 2 forks source link

Review what stats are created #5

Closed gregrs-uk closed 8 years ago

gregrs-uk commented 8 years ago

e.g. Dave F suggests 'Could a 'Relevant OSM nodes/ways without fhrs:id' statistic be added?'

gregrs-uk commented 8 years ago

‘Percentage of relevant OSM nodes/ways with FHRS match or postcode’ includes OSM nodes/ways which have an fhrs:id and postcode that both match the FHRS database, and those with a postcode but no fhrs:id. This doesn’t include those with a non-matching fhrs:id, or those for which the postcodes don’t agree (including cases where the OSM postcode is not set). This is probably misleading because establishments with a valid fhrs:id but no postcode will not be included. It’s meant as a measure of ‘completeness’, with the goal to tag establishments with a postcode and possibly an fhrs:id, but I think the label probably needs changing.

gregrs-uk commented 8 years ago

This spreadsheet showing structure of CASE ... WHEN filtering might be useful

gregrs-uk commented 8 years ago

dc82d15 improves the stats table. I think the stats present are the most helpful at the moment, so I don't plan to add a 'Relevant OSM nodes/ways without fhrs:id' statistic at the moment.