search

gregsadetsky / chrome-dont-add-custom-search-engines

Google Chrome extension that stops sites from adding custom search engines
https://chrome.google.com/webstore/detail/dont-add-custom-search-en/dnodlcololidkjgbpeoleabmkocdhacc
Other
117 stars 12 forks source link

duckduckgo.com is getting through #18

Closed Procyon-b closed 5 years ago

Procyon-b commented 6 years ago

https://duckduckgo.com/ is automatically added.

The problem is probably with the code before "autoDetect". In either "Opensearch" or "Suggestion service". I'll look into it.

Procyon-b commented 6 years ago

One of their scripts is adding it dynamically. in d2476.js: (now d2477.js) ... $("head").append('<link title="DuckDuckGo" type="application/opensearchdescription+xml" rel...

side note: I hate chrome's "view source". It's always incomplete. It does not include dynamically added elements. Fortunately I have a bookmarklet for that.

edit: their file has been updated. Anyway, the fix stands.

Procyon-b commented 6 years ago

It seems fixed with this little modification. I have moved code to a function "catchOpenSearch()", which is called twice now. content.zip

cxw42 commented 5 years ago

@gregsadetsky For the record, I didn't include this one in the v0.0.5 material since I haven't had as much time to try it. I plan to revisit this after v0.0.5 is out.

Procyon-b commented 5 years ago

I can tell you that since I use this version of the code, no SE slipped through. But I have no idea if this breaks sites.

gregsadetsky commented 5 years ago

Heya, I just tested the latest (0.0.5) version and only dontbubble.us (related to DDG) and redbubble.com slipped through (against ~100 sites). Looking great! I'm going to push it now.

Thank you both as always for the stellar amazing work!

EDIT: Just deployed to the store!

Procyon-b commented 5 years ago

Tested the 2 sites with the latest code (see content.zip on Aug 23 above), and it blocks those too. :)

edit: by the way, dontbubble.us redirects me to duckduckgo.com/privacy. So I can't test on the domain dontbubble.us

cxw42 commented 5 years ago

@Procyon-b Are you comfortable enough with the GitHub workflow that you'd like to open a pull request for the 2018/08/23 content.zip code, or would you like me to do so as I did last time?

Procyon-b commented 5 years ago

I haven't look much at the interface here. But I know I have done it before in june. The questions I asked you some weeks ago was because I didn't want to create duplicates, or unnecessary steps. I don't have time to do it right now (it's 19:55 here). You can if you want it done now. ;)

cxw42 commented 5 years ago

No worries - at your convenience :) . Once you open the PR I'll give it a try.

cxw42 commented 5 years ago

@gregsadetsky Re. https://github.com/gregsadetsky/chrome-dont-add-custom-search-engines/issues/18#issuecomment-424394445 - sometime when you have a chance, would you please update the wiki page with your list of sites? It sounds like you are testing far more than are currently listed, and I'd like to see what we have for #7. Thanks!

cxw42 commented 5 years ago

This looks good to me! redbubble.com also appears to be fixed by these changes, merged in #25. Thanks, @Procyon-b!