search

gregsadetsky / chrome-dont-add-custom-search-engines

Google Chrome extension that stops sites from adding custom search engines
https://chrome.google.com/webstore/detail/dont-add-custom-search-en/dnodlcololidkjgbpeoleabmkocdhacc
Other
118 stars 12 forks source link

[Feature Request] Add ability to remove custom search engines en mass. #24

Open chris37879 opened 5 years ago

chris37879 commented 5 years ago

[See https://github.com/gregsadetsky/chrome-dont-add-custom-search-engines/issues/24#issuecomment-475980563 below –Ed.]

Would adding a feature that allows users to bulk remove custom search engines that build up in the settings be out of place? I ask because I just installed the extension and needed to also delete old ones and this could be a nice feature for on-boarding new users.

There's a console script someone posted on superuser that can remove it, not sure if extensions can operate on chrome:// urls.

https://superuser.com/questions/1141135/google-chrome-remove-all-other-search-engines

cxw42 commented 5 years ago

Chris, thanks for the link and feedback! I think this would be a nice feature to include. Unfortunately, extensions are not allowed to run on chrome: pages. (If they were, for example, a malicious extension could present itself from being uninstalled.) Extensions can't even link to chrome: pages, in fact, although they can use the extension api to open chrome: pages.

Since this extension originates from SE, there are no license issues with making this code available in the extension for people to copy and paste. It would be another point of required updating, though, so including just the link would have reduced maintenance burden. @gregsadetsky what do you think?

gregsadetsky commented 5 years ago

A prompt after the extension's installation to remove all search engines is a great idea -- thank you for the suggestion! But yeah, we're limited (for good reason) in what we can do around chrome URLs.

I imagine that we could add a "thank you for installing" screen and either link to stackoverflow or show the instructions right there (for "Advanced Users"). I'm not the biggest fan of post-installation prompts/web pages popping up, though.

I'm not sure. What about adding a item to the extension icon's menu titled "Remove all search engines", and instead of doing it, showing the instructions to do so..?

chris37879 commented 5 years ago

I agree with the concerns about a post install popup that is just informational isn't great. Maybe just put the instructions in the view you can open by clicking the button. That's where I looked first for a thing to remove them after installing the extension.

On Sun, Mar 24, 2019, 10:34 Greg Sadetsky notifications@github.com wrote:

A prompt after the extension's installation to remove all search engines is a great idea -- thank you for the suggestion! But yeah, we're limited (for good reason) in what we can do around chrome URLs.

I imagine that we could add a "thank you for installing" screen and either link to stackoverflow or show the instructions right there (for "Advanced Users"). I'm not the biggest fan of post-installation prompts/web pages popping up, though.

I'm not sure. What about adding a item to the extension icon's menu titled "Remove all search engines", and instead of doing it, showing the instructions to do so..?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gregsadetsky/chrome-dont-add-custom-search-engines/issues/24#issuecomment-475975456, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7jsosMZTxJ_ezmU_hkJ0z7voFZSX_lks5vZ6kIgaJpZM4cFOkF .

cxw42 commented 5 years ago

I agree with adding a tab that opens when the user clicks the extension's button, and that has a link to the instructions. Currently clicking the button does nothing, so we have that space available.