update selectors - Githubissues

gregsadetsky / chrome-dont-add-custom-search-engines

Google Chrome extension that stops sites from adding custom search engines

https://chrome.google.com/webstore/detail/dont-add-custom-search-en/dnodlcololidkjgbpeoleabmkocdhacc

Other

118 stars 12 forks source link

update selectors #27

Closed Procyon-b closed 5 years ago

Procyon-b commented 5 years ago

[Closes #26 –Ed.]

2 selectors have been added.

[type=""] is for a page where the userscript failed, but has since been fixed. It happened once, so it's a good idea to add it.

[type*="search" i] could replace [type="search" i], but I left the old value. It can be simplified in a future release after double-checking that the wildcard doesn't fail on some circumstances.

Procyon-b commented 5 years ago

Possible enhancements: #28

cxw42 commented 5 years ago

@Procyon-b thank you! I'll take a look. The beginning of Hacktoberfest has been very crazy :) .

If you would like an additional Hacktoberfest credit, please feel free to close this PR and open a fresh one with the same changes :D .

cxw42 commented 5 years ago

Works for me on the two sites listed in #26!
I did a spot check of a few sites from the Wiki, both mobile and desktop versions. I didn't see any failures. It reminded me that, as the list grows, #7 will be increasingly important. But I'm still not sure how to implement that one! :/