search

gregsadetsky / chrome-dont-add-custom-search-engines

Google Chrome extension that stops sites from adding custom search engines
https://chrome.google.com/webstore/detail/dont-add-custom-search-en/dnodlcololidkjgbpeoleabmkocdhacc
Other
118 stars 12 forks source link

The Badge Text never show #29

Closed snowman closed 3 years ago

snowman commented 4 years ago

How do those codes work?

https://github.com/gregsadetsky/chrome-dont-add-custom-search-engines/blob/e8b215c10054aa8e96a28502ec79266be19072bf/src/bg.js#L1-L10

Description

In content.js, I could not found the code chrome.runtime.sendMessage

Document

gregsadetsky commented 4 years ago

Great point, it's quite possible that the code to show the badge was removed at some point. It's not necessarily the most important / interesting piece of code, so it might have left without anyone really noticing..! :-)

cxw42 commented 4 years ago

@gregsadetsky I see you have removed the text mentioning the badge from the Chrome Web Store entry (edit although it's still in the screenshot) --- shall we just remove that code from bg.js and move on? The whole point of the extension is to not make things appear in the UI ;) .

gregsadetsky commented 4 years ago

Definitely agree, the badge icon was not necessary, or useful. Good riddance! :-) Thank you!