search

gregsadetsky / chrome-dont-add-custom-search-engines

Google Chrome extension that stops sites from adding custom search engines
https://chrome.google.com/webstore/detail/dont-add-custom-search-en/dnodlcololidkjgbpeoleabmkocdhacc
Other
117 stars 12 forks source link

Also kill url[rel="suggestions"] and generic search GET forms #6

Closed cxw42 closed 6 years ago

cxw42 commented 6 years ago

Incorporates everybody's changes up to this point, and appears to be working in my testing on Chrome 64.

Closes #1 Closes #2 Closes #3

gregsadetsky commented 6 years ago

Going to give it a test now (finally!), report back, and then hopefully go on to merge & deploy. More news soon.

gregsadetsky commented 6 years ago

Ok, this is wonderful!! I ran through a list of 142 sites that add custom search engine and only one of them ended up not being detected by this branch -- DuckDuckGo! Pretty funny, right? :-)

This is great. I do want to say that I'm a little bit wary of the textarea-adding approach, simply because that might lead to some sites/forms breaking (those sites that expect a very specific list of inputs submitted through its forms). On the other hand, I feel like this a (very) specialized extension, so hopefully we can go with this approach for now, and see if there are issues with it.

Fantastic! Last thing would be to comment out the console.* calls, which I'll do in a subsequent commit.

I'll let everyone know once this is deployed (w00t)! For now, merging this.

Congrats &&& Huge Thanks to everyone for the great work. And your almost limitless patience. Thanks for believing. :-)

Cheers

snowbound commented 6 years ago

Well I downloaded this commit last week and just checked here. Youtube, finance.google.com and https://forum.glasswire.com/search?q=%s all showed up in my Search engine.

This may be moot though as I am seriously thinking of switching to using Firefox. Getting fed up with Google products and their lack of contacting anyone wrt to security issues re another product.

gregsadetsky commented 6 years ago

hey @snowbound I just tried youtube.com, finance.google.com and forum.glasswire.com and none of them were added as search engines.

the 0.0.2 update in the chrome extension store is still propagating (it may take up to 24 hours) -- would you mind testing it there (i.e., downloading the new version from the official store), or trying this code again directly from the master branch (into which the new code has been merged)?

thank you!

Songworks commented 6 years ago

Awesome work guys, thank you so very much!

cxw42 commented 6 years ago

Ok, this is wonderful!! I ran through a list of 142 sites that add custom search engine and only one of them ended up not being detected by this branch -- DuckDuckGo! Pretty funny, right? :-)

@gregsadetsky I checked, and as far as I can tell, DDG creates its search form using JS after the page loads. I think we'll have to accept a DDG entry in the search-engine list :) .

If you visit DDG in lynx, you get redirected to https://duckduckgo.com/lite/ instead. /lite/ uses a POST, so we don't have to worry about that one.

gregsadetsky commented 6 years ago

I think that adding a time related number defeats the goal of having a unique name (easy to find using google)

I think that we should prioritize the whitelist feature first. It will get rid of the problem for those that are witnessing the GET url "pollution" (while pointing out, using its long but obvious name, where the extra GET arg is coming from).

We can then try to come up with a good naming scheme (supposedly one of the two complicated things in CS) :-)