gregsadetsky / chrome-dont-add-custom-search-engines

Google Chrome extension that stops sites from adding custom search engines
https://chrome.google.com/webstore/detail/dont-add-custom-search-en/dnodlcololidkjgbpeoleabmkocdhacc
Other
118 stars 12 forks source link

sites that slip through and whose search engines are added #9

Closed gregsadetsky closed 6 years ago

gregsadetsky commented 6 years ago
cxw42 commented 6 years ago

@gregsadetsky Is this issue going to hold the master list referenced in #7? If so, may I suggest a wiki page instead? In an issue, commenters can only edit their own comments, and it will be harder to pull the data for automated testing.

All that said, we've seen issues on:

cxw42 commented 6 years ago

... Although, now that I think about it, if folks post live links, and all we care about in testing is that at least one form on the linked page is spoiled, we could scrape this just as well as we could scrape links off a wiki page. We just wouldn't be able to easily delete the links later if the sites changed how they searched.

In a wiki, we could have a table with URL and expected number of results (e.g., pouet 1; bleepingcomputer 2). We could scrape the table and check for that number. Anyway, let me know what you think.

gregsadetsky commented 6 years ago

great thoughts on wiki. basing off the automated testing on the wiki links is a really great one, but I'd be concerned that opening up the wiki to anyone & using those urls for testing could spell trouble. but we're not there yet. definitely let's do wiki! I'll create the page, move the links here (thank you!) there and then close this issue.

gregsadetsky commented 6 years ago

https://github.com/gregsadetsky/chrome-dont-add-custom-search-engines/wiki/Sites-known-to-be-added-as-custom-search-engines