Closed litviakk closed 1 day ago
Amazing thanks a ton!!
Sorry for the slow replies from my side, very busy week. I'll be able to look into it starting next week
Feel free to hardcode the site name in the code, no need to fetch it from the db :)
Would you be able to add a test for the opengraph tags?
Sure! I'm also thinking maybe keeping all settings and hardcoded values in one place might be easier to read (at least there would be logic there, while now they are just spread over two files). Will move them to nycnoise/settings/base.py
if no objections
Can we merge this one, and I will add other changes as follow-ups (I already have a couple of branches requiring a rebase...)
this is great, thanks!
we do want opengraph to show up on the static pages as well -- could you please make sure they do (you should be able to make a static page on your dev machine, or if you bring the prod db locally, you'll have tons of static pages to test with)
if static pages could have their opengraph title reflect the static page's title, that would be great! (and you could add a test for that as well)
finally, to clean up, could you get rid of the opengraph templatetags (meta_title
, meta_description
, etc.) and the core/opengraph.html
template that won't be used anymore?
thanks again!
all's done, let's roll!
All Opengraph tags seem to be in place