gregsadetsky / rctv

https://rctv.recurse.com
4 stars 2 forks source link

Turn app url into an actual link for previewing #1

Closed hendersonreed closed 1 year ago

hendersonreed commented 1 year ago

I was reviewing the developers page and found myself highlighting and then right-clicking in order to actually visit the app url, and I realized I could just make a PR to turn the urls into actual links!

warning: I haven't tested this yet, I am just doing this during presentations :sweat_smile:

gregsadetsky commented 1 year ago

Hey this makes a million percent sense, the issue is that the apps that do use the sdk / api can’t really be accessed (long story short if you go to them but you’re not the tv, it will fail)Could you amend your change to check first if the app object has uses_api and only add the link (on that url) if it’s false i.e. if uses_api, show the url, else, show the url + link?Thank you!!!!!!!On Nov 9, 2023, at 4:24 PM, Henderson Hummel @.***> wrote:I was reviewing the developers page and found myself highlighting and then right-clicking in order to actually visit the app url, and I realized I could just make a PR to turn the urls into actual links! warning: I haven't tested this yet, I am just doing this during presentations 😅

You can view, comment on, or merge this pull request online at:   https://github.com/gregsadetsky/rctv/pull/1

Commit Summary

68f77e4 Turn app url into an actual link for previewing

File Changes (1 file)

M
core/templates/core/developers.html
(4)

Patch Links:

https://github.com/gregsadetsky/rctv/pull/1.patch https://github.com/gregsadetsky/rctv/pull/1.diff

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

hendersonreed commented 1 year ago

hey hey! I fixed it I think - let me know if further changes are needed, but I think I did the right thing!

gregsadetsky commented 1 year ago

PERFECT THANKS!