Open xadaemon opened 1 year ago
Since only some arguments are supposed to be passed to sub-make, we might want a helper method on Args
to compile an argument string from those options which should be passed to sub-make.
Since only some arguments are supposed to be passed to sub-make, we might want a helper method on
Args
to compile an argument string from those options which should be passed to sub-make.
Yeah, I think it's a good way to do it, I will implement the function.
I have moved the submake arg str generation to arg.rs
I didn't get notified about your reviews, github... I will work on those :)
Some, I believe unrelated tests, have started failing I will make sure they are not related tomorrow.
Let me know if you want help getting this branch up to date with master; I am happy to merge master in and resolve conflicts. If you do want help, just let me know when you're at a good stopping point.
Let me know if you want help getting this branch up to date with master; I am happy to merge master in and resolve conflicts. If you do want help, just let me know when you're at a good stopping point.
I think I'm at a good stopping point, might want to get them merged before I work on the last point (the args one), maybe merge this and I open up another pr with the final improvement on that one?
Sounds good; I'll merge master into this, fix tests, and get it merged and we can continue work on this is another branch.
This is my initial solution, needs the tests and such, but I wanted to get your opinion on it before going further in this path.
Should fix #8