search

gregsdennis / Manatee.Json

A fully object-oriented approach to JSON manipulation, validation, and serialization that focuses on modeling the JSON structure rather than mere string parsing and conversion.
MIT License
198 stars 32 forks source link

JsonSchemaOptions_BasicDownload writes to Console #263

Closed reardonj closed 4 years ago

reardonj commented 4 years ago

When calling JsonSchemaRegistry.Get() I see the path to the schema written to the application's console output. This appears to be caused by JsonSchemaOptions._BasicDownload, which has a call to Console.WriteLine on its first line.

Expected behavior I expect no output to be written to the console.

gregsdennis commented 4 years ago

Might have a leftover from debugging. Thanks for catching it. I'll replace that with a logging line.

Be aware that the schema test suite has updated to include a few test that I'm failing on. I'm working to resolve them, but my build won't succeed (thus no publishing) until those pass. In the meantime, that download method can be replaced with a method you write.

gregsdennis commented 4 years ago

This is resolved in v13