ability to add custom regex for identifiying lines - Githubissues

gregsdennis / dependencies-action

A GitHub Action that enforces PR dependencies

MIT License

33 stars 10 forks source link

ability to add custom regex for identifiying lines #16

Closed ilyesAj closed 1 year ago

ilyesAj commented 1 year ago

we're using GHE enterprise, and we're unable to use this GitHub actions workflow since it's using a specific github.com regex. https://github.com/gregsdennis/dependencies-action/blob/main/index.js#L9 https://github.com/gregsdennis/dependencies-action/blob/main/index.js#L10

is it possible to either:

Define a custom regex that we can inject using global env variable
Make the GitHub url within the regex as a variable so that we can override it if needed

Example of link for a PR on Github enterprise: https://mygheurl.com/OWNER/REPO_NAME/pull/3

gregsdennis commented 1 year ago

Hi, thanks for the suggestion.

I think I can set it up for you to include custom domains as a parameter, but I don't think it's a good idea to support the user imputting their own regex. The logic is pretty tightly coupled to specific groups within the regex, and if those are missing or misaligned, then the action can't work.