search

gregsexton / MatchTag

Vim's MatchParen for HTML tags
http://www.vim.org/scripts/script.php?script_id=3818
310 stars 31 forks source link

Pathogen incompatibility due to folder name #34

Closed Cisplatin closed 7 years ago

Cisplatin commented 8 years ago

Pathogen only finds plugins if the .vim files are in a folder called plugin. Because it's called ftplugin instead, pathogen doesn't not automatically install the plugin.

If there's no reason to call it ftplugin, changing it to plugin would decrease friction for users.

gregsexton commented 8 years ago

Are you sure this is true? I have plenty of plugins using pathogen that have an ftplugin component.

Cisplatin commented 8 years ago

I've tested it on both mine and my friends' Mac, using vim 7.4, and the latest version of pathogen (undefined?).

Seems like it affects other people as well, judging by the second answer of http://stackoverflow.com/questions/3383502/pathogen-does-not-load-plugins

If you do decide to change the name, I have a PR set up at https://github.com/gregsexton/MatchTag/pull/35

leiteg commented 8 years ago

@Cisplatin @gregsexton I had the same problem with another plugin. But the real problem must be in Pathogen. I don't think it is a good idea to merge a pull request that simply renames ftplugin to plugin since ftplugin directories are for specific filetypes. After renaming, the plugin will load whenever vim starts, independently of filetype, and this could lead to conflict problems.

gishmel commented 7 years ago

I would agree with @Laranjadinho that this is definitely not a problem with the plugin but in this case by the plugin manager. Doesn't make sense to merge this in as its directly against the purpose of the filetype features in vim.