Suggestions :)

[Silex]

So, I did play a bit with gitv and I have somes questions/suggestions:

1. Is it possible to create a g:somevar so you can choose wether to open the browser in a new tab or not? do you need it to be in a new tab?
2. I know you can press enter to naviguate a whole bunch of stuff (tree sha1 shows list of affected files, diff line opens vimdiff mode, etc). Until now to "go back" I use or I go to the browser window and press enter again, is that the intended way?
3. Can you make it so that when we press enter on a parent sha1, the browser window selection changes to reflect reality?

So far the plugin is great! I realised it pretty much made the extradite plugin useless?!

Anyway, thanks a lot! It's a sweet plugin! Philippe

[gregsexton]

Philippe,

It would be possible to create a configuration option. Currently gitv starts in a new tab because that is how I originally had it setup in my .vimrc. The reasoning here is that because it creates two new windows, both of which require a fair amount of screen real estate, it would make most sense to open a new tab and not disturb the current windows. A new tab also lends to being able to open the browser mode, do whatever and then close it without disturbing anything. This is how I use gitv.

I think some of the logic, particularly on closing, makes the assumption that gitv 'owns' all of the windows in the tab. As a result, adding this isn't going to be quite as straightforward as I would like. I will add it to my to do list though.

I presume in your second point your referring to the fugitive buffer opened by gitv. I think there are mappings that help with navigating. See :help fugitive-mappings. I tend to use <c-o> myself. I think C might help though.

I'm not sure how difficult your third request is without looking into it, but I think it's a good idea and I will definitely be looking at it.

Thanks for the suggestions,

Greg

[Silex]

Closing this as I don't use vim anymore :)

[gregsexton]

Out of curiosity, what do you use now?

[Silex]

Emacs, where I use https://github.com/magit/magit which has a gitv equivalent. The reasons of my switch boiled down to:

1. vim's difficulties to talk to an asynchronous process (I want to be able to edit code while running :make or :grep, and it was very hacky to work around it).
2. My 3 years patch still not being applied despite being very simple https://groups.google.com/forum/#!searchin/vim_dev/philippe$20vaucher/vim_dev/XuinZFSYLQk/zRr0vADyQ4sJ. In emacs almost anything can be made as a package due to the fact that almost everything is emacs-lisp and thus it's more extensible.
3. Stuffs like http://emacsrocks.com/e13.html

I'm still using vim's keybindings with evil-mode, but I'm considering getting rid of and replace it with a combination of ace-jump-mode and expand-region.

[gregsexton]

Agreed. I switched to Emacs a few years ago and never looked back. I've actually contributed to magit.

[Silex]

"Great minds think alike" :wink: