gregsexton / gitv

gitk for Vim.
938 stars 59 forks source link

Add git commands 'cherry-pick', 'reset' and 'branch/tag -d' #90

Closed AlterDepp closed 8 years ago

AlterDepp commented 9 years ago

I added a few commands I often use. I tested it with version v1.1, which is available on vim.org and rebased it on master.

aschrab commented 9 years ago

These seem like useful features to me. I'm not entirely happy with the mappings for reset, but I don't have a better idea for them either. I did add a couple of comments on the commit about bits of the docs that look slightly outdated.

:+1:

AlterDepp commented 9 years ago

I added a commit to fix the typos.

AlterDepp commented 9 years ago

Hi @aschrab, will you pull it and create a new version of the plugin at vim.org? Stefan

aschrab commented 9 years ago

I don't have access to pull changes into this repository. I'm just a user/contributor like you are.

gregsexton commented 9 years ago

Thanks for adding these features. I'm happy with the mappings that begin with c or d as these are shadowing edits that you wouldn't be able to perform in a read-only buffer. b is useful though and I would like this to remain the motion for moving backwards. Maybe git manipulations should all have the same key prefix? At the cost of a few more keystrokes, this will allow this to expand to as many operations as desired. I'm happy to hear your thoughts and take suggestions on this one.

gregsexton commented 9 years ago

Also, apologies this took me so long to get to. :)

AlterDepp commented 9 years ago

Which mappings would you suggest?