Return file: prefixed paths for rendered images

gregsexton / ob-ipython

org-babel integration with Jupyter for evaluation of (Python by default) code blocks

739 stars 109 forks source link

Return file: prefixed paths for rendered images #123

Closed jamieforth closed 6 years ago

jamieforth commented 7 years ago

Allows org preview to show them inline.

Without the file: prefix returned links can be opened with org-open-at-point, but they are not displayed inline with org-toggle-inline-images.

gregsexton commented 7 years ago

This is odd, this works for me and shows the images inline. Which version of emacs and org are you running? What happens if you M-x org-redisplay-inline-images?

jamieforth commented 6 years ago

It used to work for me too, but now without the file: prefix M-x org-redisplay-inline-images no longer has any effect (other file: prefixed links in the buffer display correctly).

GNU Emacs 25.2.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.20) of 2017-09-12, modified by Debian Org mode version 9.1.1 (org-plus-contrib-20170918)

aijony commented 6 years ago

I have this issue as well. Another option would be removing all the formatting and setting the header :output file drawer

cnglen commented 6 years ago

I have the same problem.

My emacs.d is forked from https://github.com/purcell/emacs.d. Without file: prefix, C-x C-v not work.
"emacs -q", without file: prefix, C-x C-v works.

So there is something wrong with some package in https://github.com/purcell/emacs.d, I'm not sure the root cause. At the moment, I use @jamieforth 's method.

gregsexton commented 6 years ago

Just tried this out, and putting the file prefix doesn't seem to do any harm. Happy to merge! Hope this fixes the issue for everyone.