search

gregsexton / ob-ipython

org-babel integration with Jupyter for evaluation of (Python by default) code blocks
738 stars 108 forks source link

Add support for asynchrnous ipython excution. Requires :async t in th… #40

Closed girip closed 7 years ago

girip commented 8 years ago

…e paramter for src block and for exporing image output to file use :async-file file.png

dvzubarev commented 8 years ago

Hi, can you rebase on master, so that one can test your PR?

girip commented 8 years ago

Hi,

I think I rebased and resolved some conflicts on the way. After rebasing async still seems to work, atleast for me. But, I am not very familiar with elisp and please do look at the code for bugs and consistencies.

One issue which is not yet fully fixed in this PR is handling errors.

dvzubarev writes:

Hi, can you rebase on master, so that one can test your PR. —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

gregsexton commented 8 years ago

Thanks a lot for rebasing. This is very high in my list of things to look at.

ghost commented 7 years ago

Any update on this? Would be great to have.

jtmoulia commented 7 years ago

I'll try rebasing + testing this -- would love to not have Emacs be blocked on ipython src block evaluation.

girip commented 7 years ago

I rebased the PR once, but sorry for not doing it recently. The PR was a workaround for the async evaluation, but has a few bugs, it would be helpful to fix the bugs.

On Mon, Feb 13, 2017 at 12:49 PM, Thomas Moulia notifications@github.com wrote:

I'll try rebasing + testing this -- would love to not have Emacs be blocked on ipython src block evaluation.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gregsexton/ob-ipython/pull/40#issuecomment-279517646, or mute the thread https://github.com/notifications/unsubscribe-auth/ALd2MmL2MEDrsE8188uvgPYktWWl6_-7ks5rcMHogaJpZM4G2MHt .

-- -giri

dvzubarev commented 7 years ago

The PR was a workaround for the async evaluation, but has a few bugs, it would be helpful to fix the bugs.

I've been using this branch for a while. It works quite well for me, I didn't notice any bugs. But I used it mostly with :async t flag and didn't try to use :async-file file.png.

gregsexton commented 7 years ago

I pulled this down and reworked it a bit:

Just landed the merge. Let me know if you run in to any bugs. Seems to be working pretty well for me. Thanks a lot for the PR and sorry for the delay in merging.