gregswift / ansible-ipaserver

Ansible Role for configuring a FreeIPA server
15 stars 17 forks source link

Task named "Run the installer" is probably wrong. #7

Open csabapatyi opened 6 years ago

csabapatyi commented 6 years ago

Hi,

I think the tasks has an error:

- name: Run the installer
  action: command
    {{ ipaserver_base_command }}
...

This should be probably only the following I think:

- name: Run the installer
  command: >
    {{ ipaserver_base_command }}
...

Or at least I can not find anything about this Ansible "action" module. If you want I can create a pull request for it.

rackergs commented 6 years ago

action isn't the module. Its legacy ansible syntax. Is this task failing for you?

csabapatyi commented 6 years ago

Hi,

It is odd, now it is working.

Prevously the task was not failling directly. I mean I did not get error when I was running the playbook, but the actual installation does not happened. If I run 'ipactl status' I got something like "IPA is not configured... "

This is the code what I used to "solve" for me:

- name: Run the installer
  command: >
    {{ ipaserver_base_command }}
    --realm {{ ipaserver_realm }}
    --domain {{ ipaserver_domain }}
    -a {{ ipaserver_admin_password }}
    -p {{ ipaserver_dir_admin_password }}
    --hostname={{ ansible_fqdn }}
    --ip-address={{ ansible_eth0.ipv4.address }}
    {{ '--idstart=%s' % ipaserver_idstart if ipaserver_idstart | default(False) else '' }}
    {{ '--idmax=%s' % ipaserver_idmax if ipaserver_idmax | default(False) else '' }}
    {{ '--forwarder=%s' % ipaserver_dns_forwarder
       if ipaserver_dns_forwarder | default(False) else '--no-forwarders' }}
    {{ '--mkhomedir' if ipaserver_mkhomedir | default(True) else '' }}
    {{ '--setup-dns' if ipaserver_setup_dns | default(True) else '' }}
    {{ '--ssh-trust-dns' if ipaserver_ssh_trust_dns | default(True) else '' }}
    {{ '' if ipaserver_hbac_allow | default(True) else '--no_hbac_allow' }}
    {{ '' if ipaserver_setup_ntp | default(True) else '--no-ntp' }}
    {{ '' if ipaserver_configure_ssh | default(True) else '--no-ssh' }}
    {{ '' if ipaserver_configure_sshd | default(True) else '--no-sshd' }}
    {{ '' if ipaserver_ui_redirect | default(True) else '--no-ui-redirect' }}
  args:
    creates: /etc/ipa/default.conf

Ansible version: 2.3.2.0 Target machine: CentOS 7, kernel 3.10.0-514.26.2.el7.x86_64, python version: 2.7.5 IPA installed: VERSION: 4.5.0, API_VERSION: 2.228

I also had to add the following package to the 'ipaserver_packages' variable: ipa-server-dns