search

gregtatcam / imaplet-lwt

imaplet revamp with Lwt
19 stars 6 forks source link

use ppx_deriving, ppx_sexp_conv, and ppx_field_conv; remove lwt.syntax #12

Closed yomimono closed 7 years ago

yomimono commented 7 years ago

This is a fairly mechanical update of the codebase to compile in a ppx universe, rather than a camlp4 one.

gregtatcam commented 7 years ago

Travis is failing on these changes ...

yomimono commented 7 years ago

Missed the opam update; let's see whether that improves things.

gregtatcam commented 7 years ago

It is still a problem.

yomimono commented 7 years ago 
# Error: Files examples/git_store.cmx
#        and /home/travis/.opam/system/lib/git/git.cmxa
#        both define a module named Git_store

I don't know how (or whether) you'd like to solve this. My primary interest is in having a buildable imaplet-lwt as it's a reverse dependency for ocaml-dns; I'm not a user of this software, and I don't know the codebase well.

gregtatcam commented 7 years ago

The error is in Irmin, not imaplet-lwt. It has to be fixed first I presume.