Rng reseeds

[hannesm]

I removed the manual Rng.reseed -- why would you do this in the first place? Once, the Rng is initialised it uses the Lwt event loop to periodically reseed itself, there is no need for manual reseeding. I assume all code pathes call ssl_.init once.

[gregtatcam]

no, not all code paths call ssl_.init

can't merge the pull request without breaking the build. other modules that depend on tls have to be fixed first.

[hannesm]

I rebased onto master, also opam now contains a more recent conduit, thus the travis build should succeed now

[gregtatcam]

merged manually

[gregtatcam]

Cool, thanks.

On Jun 12, 2015, at 11:35 AM, Hannes Mehnert notifications@github.com wrote:

I rebased onto master, also opam now contains a more recent conduit, thus the travis build should succeed now

— Reply to this email directly or view it on GitHub https://github.com/gregtatcam/imaplet-lwt/pull/8#issuecomment-111442780.

[hannesm]

thanks! what are the Rng.reseed supposed to do? once initialised, the rng is periodically fed with entropy via the lwt event loop (https://github.com/mirleft/ocaml-nocrypto/blob/master/lwt/nocrypto_entropy_lwt.ml)...

[gregtatcam]

These are three cases where Nocrypto_entropy_lwt.initialize () is not called. Two of them are aes encryption/decryption and one more tls client. I can call the initialize method at the start of each of the application with this cases.

On Jun 12, 2015, at 11:55 PM, Hannes Mehnert notifications@github.com wrote:

thanks! what are the Rng.reseed supposed to do? once initialised, the rng is periodically fed with entropy via the lwt event loop (https://github.com/mirleft/ocaml-nocrypto/blob/master/lwt/nocrypto_entropy_lwt.ml https://github.com/mirleft/ocaml-nocrypto/blob/master/lwt/nocrypto_entropy_lwt.ml)...

— Reply to this email directly or view it on GitHub https://github.com/gregtatcam/imaplet-lwt/pull/8#issuecomment-111636264.