[Bugfix] Update draw example to new .frame(closure) signature.

gregtatum / rugl

Declarative Stateless OpenGL in Rust

MIT License

40 stars 2 forks source link

[Bugfix] Update draw example to new .frame(closure) signature. #8

Closed roSievers closed 7 years ago

roSievers commented 7 years ago

I guess you forgot to update the draw example when you rewrote the .frame() function to take one closure as a parameter. With this change cargo test won't produce any errors.

One caveat is, that you probably intend this example to be easier. Taking an empty environment and passing it on to draw isn't exactly straightforward thing to to. But I'm not sure how you could improve this. I suggest that you still merge this to get the tests to pass in the meantime.

gregtatum commented 7 years ago

Ah yeah, it would be nice to have these run as real tests. I'll probably continue to break things as I add things on to the API and decide the direction to go forward.

roSievers commented 7 years ago

Well, it seems that cargo test at least compiles them. So in a way they are already tests.