gregversteeg / corex_topic

Hierarchical unsupervised and semi-supervised topic models for sparse count data with CorEx
Apache License 2.0
627 stars 120 forks source link

Clearing self.words before saving model #14

Closed devanshuDesai closed 6 years ago

devanshuDesai commented 6 years ago

I don't get the point of clearing self.words before saving the CorEx model considering most people load the model to use .get_topics() and clearing self.words basically makes the function useless for prediction purposes

gregversteeg commented 6 years ago

I believe it was a workaround for some type of pickling bug for certain text encodings. If we went fully python3 I'm sure this would not be necessary.