[Review & Discuss] Preliminar version of bash and bash_

gregwebs / Shelly.hs

Haskell shell scripting

BSD 3-Clause "New" or "Revised" License

418 stars 88 forks source link

[Review & Discuss] Preliminar version of bash and bash_ #104

Closed adinapoli closed 9 years ago

adinapoli commented 9 years ago

Hey Greg,

this is a first naive attempt to create bash and bash_. A couple of comments:

They internally uses escaping False as it's required for the && and such
- We should probably add a note in the function documentation.
I suspect bash_ to be memory inefficient as it does not discard line by line the stdout, can we make it such without boilerplate? (i.e. piggybacking on some internal functions?)
Tests are there but are quite barebone. I didn't go overboard in testing those.

Immediate thoughts?

gregwebs commented 9 years ago

The sanitizing is brittle but will probably work fine in practice. Just make bash use run

adinapoli commented 9 years ago

I have amended the PR. I had to essentially duplicate the 2 functions in order for bash_ to use run_ but I think they are small enough for it to not be a biggie. If you can think of a way to keep this DRY then let me know and I will amend accordingly.

gregwebs commented 9 years ago

it could be DRYed, but it is only 2 spots. My rule is always DRY when there are 3.

gregwebs commented 9 years ago

thanks! released as 1.6.3

adinapoli commented 9 years ago

Thanks for reviewing and merging!