search

gregwebs / Shelly.hs

Haskell shell scripting
BSD 3-Clause "New" or "Revised" License
418 stars 88 forks source link

Add Windows and macOS builds to CI and adjust test make them pass on Windows #203

Closed gdziadkiewicz closed 2 years ago

gdziadkiewicz commented 2 years ago

201 restored Windows support in Shelly, but did not add CI builds that would "prove" that it indeed compiles and runs on Windows. This PR adds this missing piece.

During the work on adding Windows build it turned out that not all of the tests are passing. I amended the tests to make them present how currently Shelly behaves on Windows (and pass). I kind of feel that some of the behavior is expected and wanted (like the backslashes for returned paths). Others like bash which is essentially erroring underneath and symbolic links (could be working on win10, requires a fix in dependency) look like bugs.

gdziadkiewicz commented 2 years ago

@gregwebs can you give me approval for running workflows? Link to the workflow run on my fork: https://github.com/gdziadkiewicz/Shelly.hs/actions/runs/1453608852

gregwebs commented 2 years ago

This looks great! I loosened the permissions, so hopefully PRs should get their actions run now. Do you want to merge this now?

gdziadkiewicz commented 2 years ago

If it is good enough for you then yes :)