search

gregwhitaker / catnap

Partial JSON response framework for RESTful web services
Apache License 2.0
55 stars 15 forks source link

Does it work with Springboot v2.0.3? #20

Open balajisetty opened 6 years ago

balajisetty commented 6 years ago

I have very simple case of including catnap for spring boot to filter few fields. Though end results are not interrupted, i don't see catnap being active and filtering fields.

Any inputs?

gregwhitaker commented 6 years ago

Theoretically it should just work, but in practice that could be another story.

I am very busy this week and do not have the bandwidth to look into this right away. I'll try to get to it this weekend.

balajisetty commented 6 years ago

I would like to fix and contribute. Can you point to possible suspect? I understand you are busy. Share some insights if you found some thing

stefanbulzan commented 6 years ago

I've made a change that will make catnap work with spring 2x. It's an issue with the order of the converters, it seems that for spring 2x vs spring 1x there's a difference in WebMvcConfigurerAdapter.configureMessageConverters. For 1x you receive an empty list to add your converters (at the top) but for 2x the list is already filled, so the new converters will go at the end with a simple add. @gregwhitaker Please check this out.

gregwhitaker commented 6 years ago

Awesome. Thanks @stefanbulzan for the contribution. I'll take a look at this later today.

balajisetty commented 6 years ago

Thanks @stefanbulzan @gregwhitaker for looking into this issue. I did try building catnap-springboot with changes and use it. But looks like there is some more spring dependencies that need to e updated in gradle build files (I familiar with maven but not gradle).

I already see an spring dependency update enhancement in list.

DragonPulse commented 5 years ago

Is the bug is still open.?, I took latest version from Maven repository and Field filtering is not working

DragonPulse commented 5 years ago

I fixed the issue. the issue was configuration.

balajisetty commented 5 years ago

@DragonPulse, Can you check in or share configuration changes ?

balajisetty commented 5 years ago

I didn’t try again. But looks like bug is still open!

On Feb 13, 2019, at 6:51 AM, Mihir Mehta notifications@github.com wrote:

I have a similar issue where I've been trying to use catnap for spring boot v2.1.2. The response is not being filtered. I'm not sure if catnap is configured to work with spring boot 2.1.2.

Any inputs?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gregwhitaker/catnap/issues/20#issuecomment-463170964, or mute the thread https://github.com/notifications/unsubscribe-auth/AHeMSoChNPC7SRxdHireCX2gHmI3EMzHks5vM_wlgaJpZM4VyKsQ.

lijuan8 commented 5 years ago

Seems not working for me either with spring-boot 2.0.7